Add Cloned to Option, kill find_copy and get_copy in favour of explicit cloning #18914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
force-pushed
the
cloned
branch
3 times, most recently
from
9a1dcc1 to
f2876c6
Compare
|
Note: I'm reasonably confident of this patch's correctness, but my ssh connection keeps cutting out in the middle of |
|
@gankro Thanks, glad to see this. Feels neutral on ergonomics, but cuts down on API surface and adds to clarity. r=me modulo a minr nit. (Feel free to have another reviewer do r=aturon if you can't reach me.) |
|
nit addressed |
|
I knew I was going to mess up the docs. Ah well. fixed + rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #18424. r? @aturon
[breaking-change]